Plugin Deactivation mod (wingup part) - #107
Open
bms-2015 wants to merge 4 commits into
Open
Conversation
Addition to Plugin Deactivation mod (wingup) (notepad-plus-plus#107) EOL reverted to the original UNIX LF as in https://github.com/notepad-plus-plus/wingup
bms-2015
changed the title
Author
|
@donho @chcg
These two PRs are connected as part of the Plugin Deactivation mod. |
donho
requested changes
Aug 3, 2026
| -deactivate : Move the given plugin folders from SRC_ROOT (plugins dir)\r\n\ | ||
| to DEST_ROOT (plugins_disabled dir).\r\n\ | ||
| -activate : Move the given plugin folders from SRC_ROOT (plugins_disabled dir)\r\n\ | ||
| back to DEST_ROOT (plugins dir).\r\n\ |
Member
There was a problem hiding this comment.
The current format should be followed.
Also it should be as simpler as possible: -moveFolder can replace both -activate & -deactivate.
My suggestion is:
Move folder mode:\r\n\
\r\n\
gup -moveFolder APP_PATH SRC_ROOT DEST_ROOT folderName1 [folderName2 ...]\r\n\
\r\n\
-moveFolder: Move the given folder names from SRC_ROOT to DEST_ROOT.\r\n\
APP_PATH: application path to launch after the operation.\r\n\
| } | ||
|
|
||
| auto lenFrom = fFrom.length(); | ||
| wchar_t* actionFrom = new wchar_t[lenFrom + 2]; |
Member
There was a problem hiding this comment.
Use std::make_unique instead of new.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin Deactivation mod (wingup part)
🎞️ Watch the video of the mod in action
https://github.com/notepad-plus-plus/notepad-plus-plus
https://github.com/notepad-plus-plus/wingup
disabledsubfolder is excluded from plugin scanning, so deactivated plugins are never accidentally loaded.Notepad-plus-plus repository:
PowerEditor/src/WinControls/PluginsAdmin/pluginsAdmin.h
PowerEditor/src/WinControls/PluginsAdmin/pluginsAdmin.cpp
PowerEditor/src/WinControls/PluginsAdmin/pluginsAdmin.rc
PowerEditor/src/WinControls/PluginsAdmin/pluginsAdminRes.h
PowerEditor/src/MISC/PluginsManager/PluginsManager.cpp
PowerEditor/src/localization.cpp
PowerEditor/installer/nativeLang/russian.xml
PowerEditor/installer/nativeLang/english.xml
wingup repository:
src/winmain.cpp